-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add PR linting #994
ci: Add PR linting #994
Conversation
Demo starting at https://react-components-994.demos.haus |
@petermakowski Would it be worth documenting something what is a valid PR name? or is that clear enough when it fails? |
jobs: | ||
main: | ||
name: Validate PR title | ||
runs-on: ubuntu-22.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason not to use latest?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We generally try to use exact dependencies for predictable runs. Happy to change if you feel strongly about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple small questions in comments to discuss if needed, but it's fine as is as well.
Thanks, will think about updating the docs with more info next. |
Thanks. I tested how it fails, and error message is quite informative, so it's not a high priority, but once we get to the point of having automatic releases set up it would be good to have the complete process described somewhere. |
Done
This PR adds a PR Lint action that enforces conventional commits convention for pull request titles.
QA
Storybook
To see rendered examples of all react-components, run:
QA in your project
from
react-components
run:Install the resulting tarball in your project with:
QA steps
Fixes
Fixes: # .