Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add PR linting #994

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Conversation

petermakowski
Copy link
Contributor

Done

This PR adds a PR Lint action that enforces conventional commits convention for pull request titles.

  • ci: add pr lint

QA

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

  • Steps for QA.

Fixes

Fixes: # .

@webteam-app
Copy link

Demo starting at https://react-components-994.demos.haus

@bartaz
Copy link
Member

bartaz commented Nov 9, 2023

@petermakowski Would it be worth documenting something what is a valid PR name? or is that clear enough when it fails?

jobs:
main:
name: Validate PR title
runs-on: ubuntu-22.04
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason not to use latest?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally try to use exact dependencies for predictable runs. Happy to change if you feel strongly about this.

Copy link
Member

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small questions in comments to discuss if needed, but it's fine as is as well.

@bartaz bartaz changed the title ci: add pr lint Adds PR linting Nov 10, 2023
@bartaz bartaz changed the title Adds PR linting ci: Add PR linting Nov 10, 2023
@petermakowski
Copy link
Contributor Author

Couple small questions in comments to discuss if needed, but it's fine as is as well.

Thanks, will think about updating the docs with more info next.

@petermakowski petermakowski merged commit ebfbe71 into canonical:main Nov 10, 2023
6 of 7 checks passed
@bartaz
Copy link
Member

bartaz commented Nov 10, 2023

Couple small questions in comments to discuss if needed, but it's fine as is as well.

Thanks, will think about updating the docs with more info next.

Thanks. I tested how it fails, and error message is quite informative, so it's not a high priority, but once we get to the point of having automatic releases set up it would be good to have the complete process described somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants