-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: upgrade storybook to v7 #995
docs: upgrade storybook to v7 #995
Conversation
Demo starting at https://react-components-995.demos.haus |
5be9897
to
f32006b
Compare
ce52a2a
to
08befd9
Compare
All issues have been resolved and this is ready for review now @bartaz |
There seem to be some breaking changes in the styling that percy surfaces: Looks like paragraphs are rendered inside some components from Storybook? Is this some weird way of applying markdown? |
Seems like this may be caused by this bug: storybookjs/storybook#18921 |
@bartaz This seems to be correct as in mdx files each new line produces a new paragraph. I'll update this PR to conform with mdx interleaving rule https://mdxjs.com/docs/what-is-mdx/#interleaving Long term solution for this would be to move over to the new CSF story format https://storybook.js.org/docs/react/api/csf |
Seems that |
4c6a0c5
to
b45900f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great! Couple clarifying questions in comments but nothing blocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you for keeping the version up to date and fixing all the doc files to be compatible.
ca8c4ba
to
1ffc6df
Compare
Done
defaultValue
from stories https://storybook.js.org/docs/react/api/arg-types#defaultvalueQA
Storybook
To see rendered examples of all react-components, run:
QA in your project
from
react-components
run:Install the resulting tarball in your project with:
QA steps
Fixes
Fixes: # .
Screenshots