Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Charm doesn't handle missing Multus correctly #374

Merged
merged 1 commit into from
Sep 18, 2024
Merged

fix: Charm doesn't handle missing Multus correctly #374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ sudo microk8s enable multus

Install Juju and bootstrap a controller on the MicroK8S instance:
```shell
sudo snap install juju --channel=3.1/stable
sudo snap install juju --channel=3.4/stable
juju bootstrap microk8s
```

Expand Down
2 changes: 2 additions & 0 deletions src/charm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,6 +570,8 @@ def _on_bessd_pebble_ready(self, _: EventBase) -> None:
return
if not self._hugepages_are_available():
return
if not self._kubernetes_multus.multus_is_available():
return
if not self._kubernetes_multus.is_ready():
return
if not path_exists(container=self._bessd_container, path=BESSD_CONTAINER_CONFIG_PATH):
Expand Down
Loading