tpm2: Create TPM2 keys with noDA attribute if no user auth is required #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, all TPM2 keys are protected by the TPM's dictionary attack protection logic. Given that the user auth mode is immutable, we should take advantage of this to create keys that require no user auth with the noDA attribute, so that they aren't protected by the TPM's dictionary attack protection logic. This means that these keys will still be recoverable, even if the TPM is in lockout mode.
chrisccoulson
force-pushed
the
tpm2-no-da-for-no-auth-keys
branch
from
14fc136 to
b5882cd
Compare
chrisccoulson
changed the title
|
I can't request a review from you @tonyespy, but I thought you might be interested in this one :) |
pedronis
reviewed
Dec 4, 2024
| @@ -160,7 +160,7 @@ func makeSealedKeyData(tpm *tpm2.TPMContext, params *makeSealedKeyDataParams, se | |||
| } | |||
|
|
|||
| // Seal the symmetric key and nonce. | |||
| priv, pub, importSymSeed, err := sealer.CreateSealedObject(symKey[:], nameAlg, authPolicyDigest) | |||
| priv, pub, importSymSeed, err := sealer.CreateSealedObject(symKey[:], nameAlg, authPolicyDigest, !requireAuthValue) | |||
There was a problem hiding this comment.
probably worth having a comment here explaining !RequireAuthValue policy/logic
There was a problem hiding this comment.
I've added a comment here now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, all TPM2 keys are protected by the TPM's dictionary attack
protection logic. Given that the user auth mode is immutable, we should
take advantage of this to create keys that require no user auth with the
noDA attribute, so that they aren't protected by the TPM's dictionary
attack protection logic. This means that these keys will still be
recoverable, even if the TPM is in lockout mode.