fix: self serve track creation optional params (#4823)

* fix: optional parameters * fix: remove unnecessary/broken state
canonical · Aug 28, 2024 · 81069dd · 81069dd
1 parent 4fc3e3f
commit 81069dd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/static/js/publisher/release/components/releasesHeading.js b/static/js/publisher/release/components/releasesHeading.js
@@ -78,7 +78,7 @@ function ReleasesHeading(props) {
   const [trackGuardrailsStatus, setTrackGuardrailsStatus] = useState(null);
   const [guardrailsLoading, setGuardrailsLoading] = useState(true);
 
-  const [isTrackNameFilled, setIsTrackNameFilled] = useState(false);
+  const isTrackNameFilled = trackName.trim().length > 0;
   const [isLoading, setIsLoading] = useState(false);
   const [notification, setNotification] = useState(null);
 
@@ -134,7 +134,6 @@ function ReleasesHeading(props) {
     setTrackNameError("");
     const { value } = event.target;
     setTrackName(value);
-    setIsTrackNameFilled(value.trim().length > 0);
   };
 
   const handleVersionPatternChange = (event) => {

diff --git a/webapp/store/views.py b/webapp/store/views.py
@@ -414,12 +414,12 @@ def sitemap():
     @exchange_required
     def post_create_track(snap_name):
         track_name = flask.request.form["track-name"]
-        version_pattern = flask.request.form["version-pattern"]
-        auto_phasing_percentage = flask.request.form[
+        version_pattern = flask.request.form.get("version-pattern")
+        auto_phasing_percentage = flask.request.form.get(
             "automatic-phasing-percentage"
-        ]
+        )
 
-        if auto_phasing_percentage:
+        if auto_phasing_percentage is not None:
             auto_phasing_percentage = float(auto_phasing_percentage)
 
         response = publisher_api.create_track(