Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added endpoint for install badge #4883

Merged
merged 7 commits into from
Oct 16, 2024
Merged

feat: added endpoint for install badge #4883

merged 7 commits into from
Oct 16, 2024

Conversation

ilayda-cp
Copy link
Contributor

@ilayda-cp ilayda-cp commented Oct 15, 2024 •
edited
Loading

Done

  • Added an endpoint that returns the badge svgs.

How to QA

Testing

  • This PR has tests
  • No testing required (explain why): probably a temporary solution

Issue / Card

Fixes #WD-15869

@webteam-app
Copy link

Demo

Jenkins

demos.haus

@ilayda-cp ilayda-cp self-assigned this Oct 16, 2024
@ilayda-cp ilayda-cp marked this pull request as ready for review October 16, 2024 07:02
steverydz
steverydz approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ilayda-cp ilayda-cp merged commit cd66977 into main Oct 16, 2024
11 checks passed
@ilayda-cp ilayda-cp deleted the WD-15869-security-header-badge-issue branch October 16, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steverydz steverydz steverydz approved these changes

Assignees

@ilayda-cp ilayda-cp

Labels
Review: Code needed Review: QA needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilayda-cp @webteam-app @steverydz