tests: verify that factory reset after remodeling to a new snapd works #14471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Run Nested -auto-
valentindavid
force-pushed
the
valentindavid/remodel-then-factory-reset
branch
from
e820f9a to
21ed272
Compare
valentindavid
force-pushed
the
valentindavid/remodel-then-factory-reset
branch
from
21ed272 to
4b3991d
Compare
valentindavid
added
the
Run nested
pedronis
force-pushed
the
fde-manager-features
branch
from
fcc5e2e to
24018ee
Compare
valentindavid
force-pushed
the
valentindavid/remodel-then-factory-reset
branch
from
4b3991d to
f463a03
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fde-manager-features #14471 +/- ##
=======================================================
Coverage ? 78.84%
=======================================================
Files ? 1093
Lines ? 147881
Branches ? 0
=======================================================
Hits ? 116592
Misses ? 24010
Partials ? 7279
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
valentindavid
force-pushed
the
valentindavid/remodel-then-factory-reset
branch
2 times, most recently
from
3fe46ac to
29dd378
Compare
|
This might still need #14718 to work. We will see. |
valentindavid
force-pushed
the
valentindavid/remodel-then-factory-reset
branch
4 times, most recently
from
c0efc73 to
d43620a
Compare
|
We are missing a piece, I have forgotten about that. We need to be able to convert LUKS2 disk without tokens to ones with tokens, just for the names, so we can rename and delete them. |
|
I have opened canonical/secboot#349 to have a way to write factory reset in a way that works. |
Until now, we were just delete old keys on factory-reset instead of renaming if cryptsetup was too old. But this is a bit too dangerous. Instead we copy-delete them. Second, we need to convert old keyslots to have a name so we can remove them after.
valentindavid
force-pushed
the
valentindavid/remodel-then-factory-reset
branch
from
d43620a to
bfbb339
Compare
|
This also depends on canonical/secboot#355 |
This was referenced Dec 10, 2024
|
Draft, because it needs PRs to be merged on secboot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does not work yet.
This depends on #14304. It also has a commit in common with #14305 (fakestore tracks)