tests: measure state lock #14874
Open
tests: measure state lock #14874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiocazzolato
force-pushed
the
tests-measure-state-lock
branch
from
0d1c64f to
f46e537
Compare
sergiocazzolato
added
the
Needs Samuele review
pedronis
reviewed
Dec 20, 2024
| @@ -139,6 +142,7 @@ func (s *State) Modified() bool { | |||
|
|
|||
| // Lock acquires the state lock. | |||
| func (s *State) Lock() { | |||
| s.lockStart = osutil.GetLockStart() | |||
There was a problem hiding this comment.
shouldn't this be done with the lock taken? otherwise just the tentative themselves to lock will race/dirty lockStart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows to collect the time the snapd state file is locked. To collect the results it is required to include the test snapd-state-lock and make sure just 1 worker is used.
SPREAD_SNAPD_STATE_LOCK_THRESHOLD_MS=15 SPREAD_USE_SNAPD_SNAP_URL= SPREAD_USE_PREBUILT_SNAPD_SNAP=false ./run-spread -artifacts .artifacts google:ubuntu-22.04-64:tests/main/snapd-state-lock google:ubuntu-22.04-64:tests/smoke/
this is an example of the smoke suite with threshold=15ms: https://paste.ubuntu.com/p/vkcMdcGTnM/
this is an example of the smoke suite with threshold=100ms: https://paste.ubuntu.com/p/XTn8jZ62pJ/