t/l/f/store: make the fake store aware of components #14882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelpires
reviewed
Dec 19, 2024
tests/lib/fakestore/cmd/fakestore/cmd_new_snap_resource_pair.go
Outdated
Show resolved
Hide resolved
| containers: map[snap.Revision]string{ | ||
| snap.R(5): filepath.Join(s.store.blobDir, "foo_1_all.snap"), | ||
| snap.R(6): filepath.Join(s.store.blobDir, "foo_2_all.snap"), | ||
| revisions: map[snap.Revision]availableSnap{ |
There was a problem hiding this comment.
Missed a commit, sorry, added now. 26eb211
tests/lib/fakestore/cmd/fakestore/cmd_new_snap_resource_revision.go
Outdated
Show resolved
Hide resolved
andrewphelpsj
force-pushed
the
fakestore-component-aware
branch
from
b58b2ec to
c1f8eba
Compare
github-actions
bot
added
the
Needs Documentation -auto-
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14882 +/- ##
==========================================
+ Coverage 78.20% 78.22% +0.01%
==========================================
Files 1151 1155 +4
Lines 151396 152775 +1379
==========================================
+ Hits 118402 119502 +1100
- Misses 25662 25889 +227
- Partials 7332 7384 +52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andrewphelpsj
force-pushed
the
fakestore-component-aware
branch
from
c1f8eba to
e93a77b
Compare
olivercalder
approved these changes
Dec 19, 2024
andrewphelpsj
added
the
Run nested
…files being named <name>.comp.comp
andrewphelpsj
force-pushed
the
fakestore-component-aware
branch
from
e93a77b to
a5a78c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will let us test things with the fake store that use components.