s/seedwriter: allow using snaps and components with improper file extensions with IgnoreOptionFileExtentions flag

[andrewphelpsj]

No description provided.

[pedronis]

question

[pedronis]

thank you, unit tests question

[olivercalder]

Code LGTM!

If we're going to have exceptions for file extensions using this new flag, what use cases do we have for enforcing the file extension vs not enforcing it? Would it be undesirable to simply stop enforcing it everywhere, and have no flag?

[andrewphelpsj]

@olivercalder those checks are to ensure consistency when creating seeds from the image package. Since we support things like snap prepare-image --snap snap-name or snap prepare-image --snap ./some-path-to-snap.snap, we want to make sure that we're parsing the args and then using them correctly as either snap names or paths.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.08%. Comparing base (24a0034) to head (94c6766).
Report is 75 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #14891      +/-   ##
==========================================
- Coverage   78.20%   78.08%   -0.12%     
==========================================
  Files        1151     1130      -21     
  Lines      151396   151468      +72     
==========================================
- Hits       118402   118278     -124     
- Misses      25662    25894     +232     
+ Partials     7332     7296      -36     

Flag	Coverage Δ
unittests	78.08% <100.00%> (-0.12%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.