snapcraft: build and use patchelf 0.18 #14908
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyga
requested changes
Jan 9, 2025
build-aux/snap/snapcraft.yaml
Outdated
| - g++ | ||
| - pkg-config | ||
| - wget | ||
| source: https://github.com/NixOS/patchelf/releases/download/0.18.0/patchelf-0.18.0.tar.bz2 |
There was a problem hiding this comment.
Could we use the Ubuntu or Debian archive here?
http://archive.ubuntu.com/ubuntu/pool/universe/p/patchelf/patchelf_0.18.0.orig.tar.gz
Debian applies two patches that we should consider as well.
bboozzoo
force-pushed
the
bboozzoo/patchelf-fix
branch
from
7bd74d2 to
d341191
Compare
bboozzoo
force-pushed
the
bboozzoo/patchelf-fix
branch
from
d341191 to
c2a58bf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14908 +/- ##
==========================================
+ Coverage 78.20% 78.22% +0.02%
==========================================
Files 1151 1157 +6
Lines 151396 152941 +1545
==========================================
+ Hits 118402 119642 +1240
- Misses 25662 25912 +250
- Partials 7332 7387 +55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bboozzoo
force-pushed
the
bboozzoo/patchelf-fix
branch
from
c2a58bf to
d13b413
Compare
valentindavid
approved these changes
Jan 10, 2025
build-aux/snap/snapcraft.yaml
Outdated
| # as of 0.18.0-1.1build1 in Oracular, here are no relevant patches to apply | ||
| source: http://archive.ubuntu.com/ubuntu/pool/universe/p/patchelf/patchelf_0.18.0.orig.tar.gz | ||
| source-checksum: sha256/1451d01ee3a21100340aed867d0b799f46f0b1749680028d38c3f5d0128fb8a7 | ||
| override-prime: | |
There was a problem hiding this comment.
I think you can do prime: [-*] also.
Patching with patchelf 0.14.3 available in 22.04 produces the result
binaries get silently broken and break parsing with python-elfutils.
Inspectign a patched binary with readelf also shows a warning like so:
snapcraft-snapd-on-amd64-for-amd64-1579591 ../project# readelf -h snapd.orig
ELF Header:
Magic: 7f 45 4c 46 02 01 01 00 00 00 00 00 00 00 00 00
Class: ELF64
Data: 2's complement, little endian
Version: 1 (current)
OS/ABI: UNIX - System V
ABI Version: 0
Type: DYN (Position-Independent Executable file)
Machine: Advanced Micro Devices X86-64
Version: 0x1
Entry point address: 0x4800e0
Start of program headers: 64 (bytes into file)
Start of section headers: 680 (bytes into file)
Flags: 0x0
Size of this header: 64 (bytes)
Size of program headers: 56 (bytes)
Number of program headers: 12
Size of section headers: 64 (bytes)
Number of section headers: 37
Section header string table index: 35
readelf: Warning: Section 0 has an out of range sh_link value of 72
The upstream patchelf 0.18 is fixed, so do a local build patchelf and
use it instead of a distro package.
Signed-off-by: Maciej Borzecki <[email protected]>
bboozzoo
force-pushed
the
bboozzoo/patchelf-fix
branch
from
d13b413 to
77f4c9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patching with patchelf 0.14.3 available in 22.04 produces the result binaries get silently broken and break parsing with python-elfutils.
Inspectign a patched binary with readelf also shows a warning like so:
The upstream patchelf 0.18 is fixed, so do a local build patchelf and use it instead of a distro package.
Related: SNAPDENG-34352
Will need a rebase once #14901 lands