Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s/a/notify: add proper version handling to the notification protocol #14914

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

olivercalder
Copy link
Member

@olivercalder olivercalder commented Jan 10, 2025

Add versioning to the AppArmor notification protocol, do compatibility checks when registering a listener on the notify socket, and correctly validate incoming message versions against the listener version and set outgoing message versions correctly.

This work is tracked internally by https://warthogs.atlassian.net/browse/SNAPDENG-34337

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 55 lines in your changes missing coverage. Please review.

Project coverage is 78.23%. Comparing base (24a0034) to head (734c8a1).
Report is 95 commits behind head on master.

Files with missing lines Patch % Lines
sandbox/apparmor/notify/notify.go 0.00% 28 Missing ⚠️
sandbox/apparmor/notify/version.go 18.18% 18 Missing ⚠️
sandbox/apparmor/notify/message.go 47.05% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14914      +/-   ##
==========================================
+ Coverage   78.20%   78.23%   +0.02%     
==========================================
  Files        1151     1151              
  Lines      151396   152942    +1546     
==========================================
+ Hits       118402   119649    +1247     
- Misses      25662    25909     +247     
- Partials     7332     7384      +52     
Flag Coverage Δ
unittests 78.23% <28.57%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant