Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o/snapstate: do not restart again for snapd along the undo path inside undoUnlinkCurrentSnap #14917

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Meulengracht
Copy link
Member

@Meulengracht Meulengracht commented Jan 10, 2025

Actually we skip the entire link code for snapd as this has already been done in undoLinkSnap. Add a wait for restart/reboot in undoRemoveAlias

REF: SNAPDENG-34315

… undoUnlinkCurrentSnap, actually we skip the entire link code for snapd as this has already been done in undoLinkSnap. Add a wait for restart in undoRemoveAlias
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.22%. Comparing base (24a0034) to head (c4521ae).
Report is 96 commits behind head on master.

Files with missing lines Patch % Lines
overlord/snapstate/handlers.go 40.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14917      +/-   ##
==========================================
+ Coverage   78.20%   78.22%   +0.01%     
==========================================
  Files        1151     1158       +7     
  Lines      151396   152955    +1559     
==========================================
+ Hits       118402   119643    +1241     
- Misses      25662    25921     +259     
- Partials     7332     7391      +59     
Flag Coverage Δ
unittests 78.22% <40.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Meulengracht Meulengracht changed the title o/snapstate: do not reboot again for snapd along the undo path inside undoUnlinkCurrentSnap o/snapstate: do not restart again for snapd along the undo path inside undoUnlinkCurrentSnap Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant