Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing yamllint file to snap projects #77

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Add missing yamllint file to snap projects #77

merged 1 commit into from
Sep 11, 2024

Conversation

samuelallan72
Copy link
Contributor

No description provided.

@samuelallan72 samuelallan72 requested a review from a team as a code owner September 11, 2024 02:11
@samuelallan72
Copy link
Contributor Author

This should fix canonical/dcgm-snap#14

aieri
aieri approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@aieri aieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I think we should start considering having hierarchical configs.

@samuelallan72 samuelallan72 merged commit f22f264 into main Sep 11, 2024
45 checks passed
@samuelallan72 samuelallan72 deleted the yamllint branch September 11, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneo8 jneo8 jneo8 approved these changes

@aieri aieri aieri approved these changes

@Pjack Pjack Awaiting requested review from Pjack Pjack is a code owner automatically assigned from canonical/soleng-reviewers

@gabrielcocenza gabrielcocenza Awaiting requested review from gabrielcocenza gabrielcocenza is a code owner automatically assigned from canonical/soleng-reviewers

@rgildein rgildein Awaiting requested review from rgildein rgildein is a code owner automatically assigned from canonical/soleng-reviewers

@Deezzir Deezzir Awaiting requested review from Deezzir Deezzir is a code owner automatically assigned from canonical/soleng-reviewers

@chanchiwai-ray chanchiwai-ray Awaiting requested review from chanchiwai-ray chanchiwai-ray is a code owner automatically assigned from canonical/soleng-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samuelallan72 @aieri @jneo8