-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oracular update for apt-hook #3365
base: main
Are you sure you want to change the base?
Conversation
PR ChecklistHow to use this checklistHow to use this checklistPR AuthorFor each section, check a box when it is true. PR ReviewerCheck that the PR checklist action did not fail. Bug ReferencesNone. Confirm
How to properly reference fixed bugs
Test UpdatesUnit Tests
Integration Tests
Documentation
Does this PR require review from someone outside the core ubuntu-pro-client team?
|
9589482
to
898f2cd
Compare
1374aac
to
3676b47
Compare
3676b47
to
3fee5da
Compare
3fee5da
to
26b36be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the very long delay.
26b36be
to
fc41ebc
Compare
fc41ebc
to
a2d21db
Compare
Updated @orndorffgrant |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dheyay I know that you are adding a test for APT news, but I wonder if we should add an orocular integration test for the json-hook
changes
Fixes: LP #2086753
a2d21db
to
6151922
Compare
@lucasmoura I would say we can probably do without a dedicated test since the updated test acts like a dedicated oracular test for the json-hook. It checks the formatting for the apt-news message as well as the summary for the number of packages. Let me know if that works, I would not mind adding a short test to check for formatting of updates/packages as well. |
Updated with the test @lucasmoura @orndorffgrant |
Why is this needed?
This PR solves all of our problems because it correctly formats apt news and apt messages for oracular.
Fixes: LP #2086753
Test Steps