Empty definition from google #204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using our own, use the google one in the predefined repository.
Dart code was generated with 3.7.12.
didrocks
force-pushed
the
empty-definition-from-google
branch
2 times, most recently
from
119b3c2
to
8e2b019
Compare
didrocks
force-pushed
the
empty-definition-from-google
branch
from
8e2b019
to
9d3f69d
Compare
|
Ok, so there are some CI jobs failing related to Flutter. I have regenerated the binding and tried to do the API change aligning Flutter version (3.7.12). |
|
As discussed on ubuntu/adsys#750, this actually has more drawbacks than advantages. Let’s keep decoupled from the google repo as long as we don’t use other types of messages. Withdrawing then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using our own, use the empty google message in the predefined repository.