Skip to content

Commit

Permalink
Quote wrapper signpost is called "signpost_image" rather than "logo"
Browse files Browse the repository at this point in the history
  • Loading branch information
jmuzina committed Aug 13, 2024
1 parent aa0f4e2 commit cb2d5c4
Show file tree
Hide file tree
Showing 9 changed files with 19 additions and 19 deletions.
16 changes: 8 additions & 8 deletions templates/_macros/quote-wrapper.jinja
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
- citation_name (string) (optional): The name of the source being quoted
- citation_title (string) (optional): The title of the source being quoted
Slots
- logo (optional): The logo of the source being quoted
- signpost_image (optional): The signpost_image of the source being quoted
- heading_link (optional): Link to be displayed beside the heading text
- cta (optional): Contents of the call to action block to be displayed below the quote
- image (optional): An image to be displayed below the quote
Expand All @@ -22,8 +22,8 @@
{% set has_heading_link = heading_link_content|trim|length > 0 %}
{% set has_heading_text = heading_text|length > 0 %}
{% set has_heading_row = has_heading_text or has_heading_link %}
{% set logo_content = caller('logo') %}
{% set has_logo = logo_content|trim|length > 0 %}
{% set signpost_image_content = caller('signpost_image') %}
{% set has_signpost_image = signpost_image_content|trim|length > 0 %}
{% set has_citation = citation_name|trim|length > 0 %}
{% set has_citation_title = has_citation and citation_title|trim|length > 0 %}
{% set cta_content = caller('cta') %}
Expand Down Expand Up @@ -82,20 +82,20 @@
</div>
{% endif -%}
<div class="row">
{% if has_logo -%}
<!--Optional signpost logo-->
{% if has_signpost_image -%}
<!--Optional signpost image-->
<div class="col-3">
<div class="row">
<div class="col-2">
<div class="p-section--shallow">
{{ logo_content }}
{{ signpost_image_content }}
</div>
</div>
</div>
</div>
{% endif -%}
{#- Skip to fourth column if the logo (which takes up first three columns) is missing -#}
<div class="col-9{% if not has_logo %} col-start-large-4{% endif %}">
{#- Skip to fourth column if the signpost_image (which takes up first three columns) is missing -#}
<div class="col-9{% if not has_signpost_image %} col-start-large-4{% endif %}">
{% if has_citation -%}
<!-- When a citation is present, wrap the quote and citation in a nested grid to space them properly -->
<div class="row">
Expand Down
4 changes: 2 additions & 2 deletions templates/docs/examples/patterns/quote-wrapper/combined.html
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@
{% block content %}
{% with is_combined = true %}
<section>{% include 'docs/examples/patterns/quote-wrapper/h2.html' %}</section>
<section>{% include 'docs/examples/patterns/quote-wrapper/h2-no-logo.html' %}</section>
<section>{% include 'docs/examples/patterns/quote-wrapper/h2-no-signpost.html' %}</section>
<section>{% include 'docs/examples/patterns/quote-wrapper/h2-no-citation.html' %}</section>
<section>{% include 'docs/examples/patterns/quote-wrapper/h4.html' %}</section>
<section>{% include 'docs/examples/patterns/quote-wrapper/h4-no-logo.html' %}</section>
<section>{% include 'docs/examples/patterns/quote-wrapper/h4-no-signpost.html' %}</section>
<section>{% include 'docs/examples/patterns/quote-wrapper/h4-no-citation.html' %}</section>
{% endwith %}
{% endblock %}
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<a href="#">All the success stories ›</a>
{%- endif -%}

{%- if slot == 'logo' -%}
{%- if slot == 'signpost_image' -%}
<img src="https://assets.ubuntu.com/v1/82122de1-rexroth_bosch_logo.png" width="178" alt="Rexroth Bosch Logo">
{%- endif -%}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{% extends "_layouts/examples.html" %}
{% from "_macros/quote-wrapper.jinja" import quote_wrapper %}

{% block title %}Quote Wrapper / H2 Quote without logo{% endblock %}
{% block title %}Quote Wrapper / H2 Quote without signpost{% endblock %}
{% block standalone_css %}patterns_all{% endblock %}

{% block content %}
Expand Down
2 changes: 1 addition & 1 deletion templates/docs/examples/patterns/quote-wrapper/h2.html
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<a href="#">All the success stories ›</a>
{%- endif -%}

{%- if slot == 'logo' -%}
{%- if slot == 'signpost_image' -%}
<img src="https://assets.ubuntu.com/v1/82122de1-rexroth_bosch_logo.png" width="178" alt="Rexroth Bosch Logo">
{%- endif -%}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<a href="#">All the success stories ›</a>
{%- endif -%}

{%- if slot == 'logo' -%}
{%- if slot == 'signpost_image' -%}
<img src="https://assets.ubuntu.com/v1/82122de1-rexroth_bosch_logo.png" width="178" alt="Rexroth Bosch Logo">
{%- endif -%}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{% extends "_layouts/examples.html" %}
{% from "_macros/quote-wrapper.jinja" import quote_wrapper %}

{% block title %}Quote Wrapper / H4 Quote without logo{% endblock %}
{% block title %}Quote Wrapper / H4 Quote without signpost{% endblock %}
{% block standalone_css %}patterns_all{% endblock %}

{% block content %}
Expand Down
2 changes: 1 addition & 1 deletion templates/docs/examples/patterns/quote-wrapper/h4.html
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<a href="#">All the success stories ›</a>
{%- endif -%}

{%- if slot == 'logo' -%}
{%- if slot == 'signpost_image' -%}
<img src="https://assets.ubuntu.com/v1/82122de1-rexroth_bosch_logo.png" width="178" alt="Rexroth Bosch Logo">
{%- endif -%}

Expand Down
6 changes: 3 additions & 3 deletions templates/docs/patterns/quote-wrapper/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ The quote wrapper pattern is composed of the following elements:
| ------------------------- | ------------------------------------------------------------------------------------------- |
| Quote text (**required**) | Quote text |
| Header | Header text & CTA. Useful for adding a title/link that describes all of a series of quotes. |
| Logo | Logo to associate with the quote |
| Signpost image | Small image to display at the left/top of the quote, such as a logo or a portrait. |
| Image | Image to associate with the quote |
| Citation name | Name of the citation's source |
| Citation title | Title of the citation's source |
Expand All @@ -34,7 +34,7 @@ If the quote is not associated with a specific brand or entity, or no logo is av
Set the second grid column in the quote row to start in the fourth column with <code>.col-start-large-4</code> to make up for
the space that would normally be taken up by the signpost logo.

<div class="embedded-example"><a href="/docs/examples/patterns/quote-wrapper/h2-no-logo" class="js-example">
<div class="embedded-example"><a href="/docs/examples/patterns/quote-wrapper/h2-no-signpost" class="js-example">
View example of the quote wrapper pattern with H2 text, without a signpost logo.
</a></div>

Expand All @@ -60,7 +60,7 @@ If the quote is not associated with a specific brand or entity, or no logo is av
Set the second grid column in the quote row to start in the fourth column with <code>.col-start-large-4</code> to make up for
the space that would normally be taken up by the signpost logo.

<div class="embedded-example"><a href="/docs/examples/patterns/quote-wrapper/h4-no-logo" class="js-example">
<div class="embedded-example"><a href="/docs/examples/patterns/quote-wrapper/h4-no-signpost" class="js-example">
View example of the quote wrapper pattern with H2 text, without a signpost logo.
</a></div>

Expand Down

0 comments on commit cb2d5c4

Please sign in to comment.