Apply review comments

canonical · Jul 1, 2024 · d0dbfcc · d0dbfcc
1 parent ddd37f7
commit d0dbfcc
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/scss/_patterns_navigation-reduced.scss b/scss/_patterns_navigation-reduced.scss
@@ -75,6 +75,7 @@
 
       &.has-search-open {
         // make sure reduced navigation items remain visible when search is open
+        // both classes needed for specificity
         .p-navigation__nav .p-navigation__items {
           display: inline-flex;
         }

diff --git a/scss/_patterns_navigation.scss b/scss/_patterns_navigation.scss
@@ -520,6 +520,7 @@ $spv-navigation-logo-bottom-position: 0.125rem; // 2px when 1rem is 16px
 
   // STICKY NAVIGATION
   .p-navigation.is-sticky,
+  // cover both --sticky and --reduced navigation
   [class^='p-navigation--'].is-sticky {
     position: sticky;
     top: 0;

diff --git a/templates/docs/examples/patterns/navigation/reduced.html b/templates/docs/examples/patterns/navigation/reduced.html
@@ -10,7 +10,7 @@
       <div class="p-navigation__tagged-logo">
         <a class="p-navigation__link" href="#">
           <div class="p-navigation__logo-tag">
-            <img class="p-navigation__logo-icon" src="https://assets.ubuntu.com/v1/82818827-CoF_white.svg">
+            <img class="p-navigation__logo-icon" src="https://assets.ubuntu.com/v1/82818827-CoF_white.svg" alt="">
           </div>
           <span class="p-navigation__logo-title">Canonical Ubuntu</span>
         </a>