feat: contextual menu css position #4915
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermakowski
force-pushed
the
feat-contextual-menu-css-position
branch
from
e1c2dd3 to
b4378c9
Compare
petermakowski
added
Review: QA needed
Review: Code needed
Feature 🎁
bartaz
reviewed
Nov 22, 2023
| @@ -16,7 +16,7 @@ | |||
| @extend %vf-has-box-shadow; | |||
|
|
|||
| display: none; | |||
| margin: 0; | |||
| margin: 0 0 $input-margin-bottom 0; | |||
There was a problem hiding this comment.
How is margin on the dropdown related to placement?
Contextual menu is absolutely positioned, so I'm not sure if bottom margin on it affects anything?
bartaz
reviewed
Nov 22, 2023
| @@ -83,6 +83,8 @@ | |||
| } | |||
|
|
|||
| .p-contextual-menu__toggle { | |||
| // Remove margin bottom for the dropdown menu to be aligned with the toggle | |||
| margin-bottom: 0; | |||
There was a problem hiding this comment.
I'm not sure if we can do that. In our example p-contextual-menu__toggle is used on the button, and in such case it would override the default margin on the button.
The fact that button has contextual menu should not affect its margin.
I guess this was the main reason to use JS for positioning - so we can calculate top position regardless of margin that element having contextual menu may have.
|
This seems stale. Feel free to reopen/revisit @petermakowski if it's still needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
This PR removes the need for using JavaScript for vertical positioning of the contextual menu and will subsequently allow to simplify implementations of this pattern.
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁,Breaking Change 💣,Bug 🐛,Documentation 📝,Maintenance 🔨.package.jsonshould be updated relative to the most recent release, following semver convention:Screenshots
No visual changes, looks exactly the same way as before. E.g.:
Notes
Somewhat related PR in react-components: canonical/react-components#1000