Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: silence import and global builtin deprecation warnings in sass build #5436

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

jmuzina
Copy link
Member

@jmuzina jmuzina commented Dec 16, 2024

Done

Silences numerous deprecation warnings from being thrown into the console output on building Vanilla. These are currently slowing the build down and are not planned to be fixed currently as we work on the new architecture.

Silenced the import and global-builtin deprecations per sass documentation

QA

  • See that sass still builds and the console output no longer has any deprecation warnings

Check if PR is ready for release

If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention
    • if existing APIs (CSS classes & macro APIs) are not changed it can be a bugfix release (x.x.X)
    • if existing APIs (CSS classes & macro APIs) are changed/added/removed it should be a minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) or macros should be listed on the what's new page.

@webteam-app
Copy link

@jmuzina jmuzina requested a review from bartaz December 16, 2024 15:40
Copy link
Member

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@bartaz bartaz added Review: Percy needed This PR needs a review of Percy for visual regressions Review: Code +1 Review: QA +1 and removed Review: Code needed Review: QA needed labels Dec 17, 2024
@jmuzina jmuzina merged commit ce1c733 into canonical:main Dec 17, 2024
11 checks passed
@jmuzina jmuzina deleted the silence-import-deprecation-warnings branch December 17, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance 🔨 Review: Code +1 Review: Percy needed This PR needs a review of Percy for visual regressions Review: QA +1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants