Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPE-1180] Adding Data Platform icon #44

Merged
merged 1 commit into from
Jul 27, 2023
Merged

[DPE-1180] Adding Data Platform icon #44

merged 1 commit into from
Jul 27, 2023

Conversation

deusebio
Copy link
Contributor

@deusebio deusebio commented Jul 26, 2023 •
edited by jira bot
Loading

Features:

  • Adding Icon as described in ticket DPE-1180
  • Adding .idea to .gitignore

taurus-forever
taurus-forever approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@taurus-forever taurus-forever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I request SQL squad to describe all changes in PR, it helps reviewers understand were changes planned on included by mistake (e.g. .gitingore here). LGTM.

@deusebio deusebio merged commit 0649ab0 into canonical:main Jul 27, 2023
10 checks passed
@deusebio deusebio deleted the wip-1180-icon branch July 27, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taurus-forever taurus-forever taurus-forever approved these changes

@zmraul zmraul zmraul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deusebio @taurus-forever @zmraul