Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPE-2710 - test: add storage scale down/up storage re-use test #52

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

marcoppenheimer
Copy link
Contributor

Changes Made

fix: actually use storage, persist both transactions + snapshots

  • Storage volume was mounted to the charm container, not to the workload. As such, storage wasn't actually persisted
  • Resolved by persisting data and data-log dirs under /var/lib/zookeeper
  • Although advice is to mount transactions + snapshots on different volumes for IO performance, Juju supports only a single volume. As ZooKeeper uses the Txn log to re-build snapshots after data loss, it's a trade-off for now

test: add scaling storage re-use test

  • Checks for existence of 'old' files after a scale-down + up
  • If 'old' files present, storage was re-used

@marcoppenheimer marcoppenheimer requested review from zmraul and deusebio and removed request for zmraul October 17, 2023 15:17
Copy link
Contributor

@zmraul zmraul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

tests/integration/ha/test_ha.py Show resolved Hide resolved
@marcoppenheimer marcoppenheimer merged commit 8fb6ece into main Oct 19, 2023
10 checks passed
@marcoppenheimer marcoppenheimer deleted the test/scale_down branch October 19, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants