[DPE-5216] S3 integration #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deusebio
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Overall, looks good! I don't have any major concern, so I'm going to approve.
I would have only one major important comment to be discussed: in Spark, we already have a s3 manager for doing similar things as done here (e.g. verifications). Why not having a similar API code or understand the differences such that we can see whether it would be possible to have a single implementation (for now, still copy and pasted in two different charms, but that is consistent one another - given we have a similar pattern and abstraction).
Also in Spark we do some tls-ca verifications. Would it be worth having it here too?
marcoppenheimer
approved these changes
Sep 2, 2024
zmraul
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See canonical/zookeeper-operator#151