Promise variants of form.validate() and field.validate() #218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #217
Also:
async
module is removed and replaced with a tiny tiny helper functionfield.validate()
now always returns an error, previously it only did so onrequired
errorsfield.validate()
rarely returned an error, the functionality ofvalidatePastFirstError
was pretty much never respected and the tests was also set up to expectvalidatePastFirstError
to not function. So in realityvalidatePastFirstError
has been active for most cases for most users, so the restoration of it's functionality can almost be a bit breaking 🤔 Any thoughts @ljharb?Are the tests enough for
form.validate()
? Its getting late here so I'm running out of time a bit, so I'm opening this PR now anyways so that this code won't be stuck on my computerTo do / decide:
validatePastFirstError
.validate()
and the one from Add a promised based handle() #215