fix: Throw 'new Error' instead of string on $search with multiple words #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nils
requested review from
BobdenOs,
danjoa,
johannes-vogel and
stewsk
as code owners
nils
changed the title
nils
changed the title
johannes-vogel
approved these changes
Feb 20, 2024
|
@nils Thanks for the PR. It should definitely be errors that we throw. |
Merged
patricebender
added a commit
that referenced
this pull request
Feb 21, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>db-service: 1.6.3</summary> ## [1.6.3](db-service-v1.6.2...db-service-v1.6.3) (2024-02-20) ### Fixed * **`cqn4sql`:** be robust against `$self.<element>` references ([#471](#471)) ([2921b0e](2921b0e)) * **cds.infer:** Always use srv.model ([#451](#451)) ([41cf4a2](41cf4a2)) * Throw 'new Error' instead of string on $search with multiple words ([#472](#472)) ([51be94d](51be94d)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Patrice Bender <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improves the error handling for #127 by showing a slightly better understandable error message to the user.
Before:
After:
Seems like CAP expects an Error instance these days, because it accesses error.message.
Parameter 'error.message' must be type of 'string'CDS setup
@sap/cds: 7.3.1
@sap/cds-compiler: 4.3.2
@sap/cds-dk (global): 7.3.2
@sap/cds-fiori: 1.1.0
@sap/cds-foss: 4.0.2
@sap/cds-mtxs: 1.12.1
@sap/eslint-plugin-cds: 2.6.3
Node.js: v18.19.1
cds-dbs: 1.3.1