Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create notification types from the file and publish from plugin #1

Merged
merged 80 commits into from
Oct 23, 2023
Merged

create notification types from the file and publish from plugin #1

merged 80 commits into from
Oct 23, 2023

Conversation

RamIndia
Copy link
Collaborator

  • check if the notification types are available in the file
  • if notifications are not existing, create them
  • interfaces to publish the notifications

AnmolBinani
AnmolBinani reviewed Aug 29, 2023
View reviewed changes
cds-plugin.js Outdated Show resolved Hide resolved
AnmolBinani
AnmolBinani reviewed Aug 29, 2023
View reviewed changes
cds-plugin.js Outdated Show resolved Hide resolved
AnmolBinani
AnmolBinani reviewed Aug 29, 2023
View reviewed changes
srv/notify.js Outdated Show resolved Hide resolved
@AnmolBinani AnmolBinani marked this pull request as draft August 29, 2023 09:33
RamIndia and others added 23 commits August 29, 2023 15:19
@RamIndia
correcting the configuration props in plugin
e066543
jest dependency added for dev
f11399c
@jeevitha011
local interface
b5d8ccf
@RamIndia
Merge pull request #2 from cap-js/jest_configuration
7e1b1b7 
jest dependency added for dev
@jeevitha011
removed global.alert
61e2749
@jeevitha011
name changes
10c0d33
@jeevitha011
Update package.json
1b1ca5c
@jeevitha011
name changes
314516c
@AnmolBinani
Merge pull request #3 from cap-js/create-class
4a6c859 
AlertNotificationService Class
@sidakphull
Local testing (#4)
8b2ca5c 
* add log2rest kind and implement log2console

* rename files

* update profiles

* rename alert to notify

* track notifications types for local

* throw error if notification type is invalid

---------

Co-authored-by: Anmol Binani <[email protected]>
@simeonPetkov96 @sidakphull
refactor notification types creation
79991f1 
* refactor notification types

* fixes

---------

Co-authored-by: I524884 <[email protected]>
@ipaunov
Refactor Post Notification
6fa55e4
@ipaunov
Fix conflicts
9bdbe42
@ipaunov
Address comments and change notify signature
51882a7
@ipaunov
Address comments
d810851
@ipaunov
Adress comments
a651a47
@ipaunov
Fix comments
06ec403
@ipaunov
Merge pull request #7 from cap-js/refactor_notification
b7ce7c1 
Refactor Post Notification
@sidakphull
add default type and fix notification types creation (#8)
c3038fb 
* add default template and bug fixes

* uncomment isGroupable check

* bug fixes

* fix null check
@RamIndia
Fix: Adding validations for properties
1c72aec
@RamIndia
Changing the default types to empty array
74674cc
@RamIndia
Merge pull request #10 from cap-js/missing-validations
98c846a 
Fix: Adding validations for properties
@ipaunov
Add test directory
303c784
@AnmolBinani AnmolBinani self-requested a review October 20, 2023 12:11
@AnmolBinani AnmolBinani merged commit fa24dd5 into main Oct 23, 2023
1 of 3 checks passed
@AnmolBinani AnmolBinani deleted the MVP branch November 14, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipaunov ipaunov ipaunov approved these changes

@AnmolBinani AnmolBinani AnmolBinani approved these changes

@simeonPetkov96 simeonPetkov96 simeonPetkov96 approved these changes

@sidakphull sidakphull Awaiting requested review from sidakphull

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@RamIndia @simeonPetkov96 @AnmolBinani @ipaunov @jeevitha011 @sidakphull