Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests for ntypes #20

Merged
merged 7 commits into from
Oct 23, 2023
Merged

Unit tests for ntypes #20

merged 7 commits into from
Oct 23, 2023

Conversation

simeonPetkov96
Copy link
Collaborator

No description provided.

@simeonPetkov96 simeonPetkov96 changed the base branch from main to MVP October 18, 2023 11:55
@simeonPetkov96 simeonPetkov96 force-pushed the unit_tests_for_ntypes branch 2 times, most recently from a1cf0a8 to bfe6df4 Compare October 18, 2023 14:59
RamIndia
RamIndia reviewed Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@RamIndia RamIndia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments

lib/notificationTypes.js Outdated Show resolved Hide resolved
lib/notificationTypes.js Outdated
processNotificationTypes,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

, is not required

@simeonPetkov96 simeonPetkov96 marked this pull request as ready for review October 19, 2023 07:36
RamIndia
RamIndia approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@RamIndia RamIndia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@RamIndia RamIndia merged commit bbad0f9 into MVP Oct 23, 2023
2 checks passed
@RamIndia RamIndia deleted the unit_tests_for_ntypes branch October 23, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RamIndia RamIndia RamIndia approved these changes

@ipaunov ipaunov Awaiting requested review from ipaunov

@sidakphull sidakphull Awaiting requested review from sidakphull

Assignees
No one assigned
Labels
For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simeonPetkov96 @RamIndia @AnmolBinani