Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with build step #70

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Fix issue with build step #70

merged 1 commit into from
Sep 19, 2024

Conversation

schiwekM
Copy link
Contributor

Closes #69

Use the new way for initialising build plugins to avoid errors during build.

BR,
Marten

Copy link

@LotharBender LotharBender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that I overlooked this plugin when searching for plugins using the outdated plugin API - thanks!

@schiwekM schiwekM merged commit bcb9ea4 into main Sep 19, 2024
4 checks passed
@schiwekM schiwekM deleted the fix/build branch September 19, 2024 08:12
@gopalanand333
Copy link

@schiwekM @LotharBender
I am still getting this error on running:

The cds build plugin 'notifications' is not compatible with this @sap/cds-dk version. Update the npm package '@cap-js/notifications/lib/build' to the latest version.

Is the fix released with newer version of notifications plugin?

@LotharBender
Copy link

LotharBender commented Sep 25, 2024

@RamIndia, @ipaunov - version 0.2.2 of the @cap-js/notifications package has not yet been released on npmjs - can anyone trigger this?

@RamIndia
Copy link
Collaborator

@simeonPetkov96 @dzhurdzhina @nvvalchev Can you take it forward?

@niklasvieth
Copy link

Any update on releasing of the new version? #71 seems to be the same issue

@LotharBender
Copy link

LotharBender commented Oct 17, 2024

@RamIndia @chgeo - is this plugin still maintained?

@yusmenrashidov
Copy link
Collaborator

Hi,
We are still working on the fix/
Regards,
Yusmen

@yusmenrashidov
Copy link
Collaborator

Hello there,
We have released the new version (0.2.2) where the fix is now applied.
Regards,
Yusmen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants