Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use package name for product ORD IDs. #41

Closed
wants to merge 4 commits into from
Closed

feat: Use package name for product ORD IDs. #41

wants to merge 4 commits into from

Conversation

ductaily
Copy link
Contributor

@ductaily ductaily commented Aug 16, 2024 •
edited
Loading

Addressing

  • ORD namespace (used as prefix in several ORD IDs) = package.name.replace(/@/,'').replace(/\//g,’'), unless explicitly configured in cds.env.ord.namespace
  • Products:
    • "ordId": "customer:product:capire.bookstore:”→ i.e. package.name.replace(/@/,'').replace(/\//g,'.')
    • "vendor": "customer:vendor:customer:”
    • "title": “capire bookstore”→ i.e. package.name.replace(/@/,'').replace(///g,'.')
    • "shortDescription": “capire bookstore" → i.e. package.name.replace(/@/,'').replace(///g,' ')

from #38

@ductaily ductaily marked this pull request as ready for review August 16, 2024 12:29
@ductaily ductaily closed this Aug 21, 2024
@ductaily
Copy link
Contributor Author

Create a PR directly on Repo: #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RoshniNaveenaS RoshniNaveenaS Awaiting requested review from RoshniNaveenaS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ductaily