fix: Use the fully-qualified names from .definitions instead of namespace #60
Conversation
aramovic79
changed the title
…-from-definitions-instead-of-csns-namespace
|
@RoshniNaveenaS @Fannon @zongqichen @RamIndia : Could you please review this pull request? Thanks. |
aramovic79
requested review from
RoshniNaveenaS,
Fannon,
zongqichen and
RamIndia
|
@zongqichen @Fannon : Could you please review once more? Thanks. |
|
@Fannon @zongqichen : Could you please review? |
| "packages": [ | ||
| { | ||
| "description": "Description for capire bookshop ord sample", | ||
| "ordId": "sap.test.cdsrc.sample:package:capirebookshopordsample-api:v1", |
There was a problem hiding this comment.
it looks it could generate multi packages by appending different suffix, I guess it's valid @Fannon.
There was a problem hiding this comment.
Ok, so does it now append suffixes or not? I thought for now, it just generates one package and assigns all the ORD resources to it? But in the future, we would add the option to automatically add the suffixes and assign the resources to the right kind of package :)
There was a problem hiding this comment.
Yes, the original code has the logic to append suffix to different type.
zongqichen
deleted the
fix/use-fqn-from-definitions-instead-of-csns-namespace
branch
Addressing the following issue from #38 :
Instead of
csn.namespace, we should use e.g.cds.model.definitions["AdminService"].model.namespace