bug fixes #17
Open
bug fixes #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capicue
reviewed
Sep 14, 2020
| def to_s | ||
| @notation | ||
| end | ||
|
|
||
| def clean_text(text) | ||
| text&.gsub(/{(.*)}/, '\1')&.gsub(/\s+/, ' ')&.strip |
There was a problem hiding this comment.
just realized I did not open a new branch for the bug fixes I proposed. My master diverged too much from the gem already. It has many fixes/features now.
The curly braces in particular I just thought it made more sense to remove them alltogether in a later commit
There was a problem hiding this comment.
There are a couple of more additions in my master , in the case you are interested, at least:
- Adding the pgn and game comment string to game object
- Fix bug when there are no moves in pgn ( only comments)
- Properly handle "don't care" variations
There was a problem hiding this comment.
@muriloime @capicue How Can I allow tag_values with special characters like Ññ?
for example in the line [WhiteTeam "NARIÑO"] I got this error:
Encoding::CompatibilityError:
incompatible encoding regexp match (UTF-8 regexp with ISO-8859-1 string)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
MoveText#variationsto[]instead ofnil(This seemed more logical to me)