Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code updated, optimized, game.to_h added #18

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

ramonrails
Copy link

  • code updated for new optimized syntax
  • rspec updated from should to expect syntax
  • new game specs added with addition test PGNs
  • used constants for pieces and more, instead of strings. Example: PGN::CODE[:piece][:r]
  • all strings frozen now
  • rspec config deprecation warning resolved
  • all test cases green
  • move_text.rb class separated (recommended convention: one class per file)
  • guard clauses added instead of if blocks covering the entire block code
  • code optimized like the example given below

original

val ||= "P"
      @piece = self.black? ?
        val.downcase :
        val

updated (same output, one liner)

      @piece = (val || PGN::CODE[:piece][:P]).send(black? ? :downcase : :itself)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant