edgetest bump versions #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fdosani
requested review from
ak-gupta,
jdawang and
gladysteh99
as code owners
jdawang
force-pushed
the
edgetest-bump
branch
from
5b19f9d to
73bfde7
Compare
|
I don't want to approve my own changes so @gladysteh99 ? |
gladysteh99
reviewed
Nov 20, 2024
pyproject.toml
Outdated
| @@ -6,7 +6,7 @@ authors = [ | |||
| { name="Faisal Dosani", email="[email protected]" }, | |||
| ] | |||
| license = {text = "Apache Software License"} | |||
| dependencies = ["boto3<=1.35.53,>=1.9.92", "PyYAML<=6.0.1,>=5.1", "pandas<=2.2.3,>=1.5.0", "numpy<=2.0.2,>=1.22.0", "polars>=0.20.0", "pyarrow>=10.0.1"] | |||
| dependencies = ["boto3<=1.35.63,>=1.9.92", "PyYAML<=6.0.1,>=5.1", "pandas<=2.2.3,>=0.25.2", "numpy<=2.1.3,>=1.22.0", "polars>=0.20.0", "pyarrow>=10.0.1"] | |||
There was a problem hiding this comment.
pyarrow backed datatype is only supported from pandas 1.5.0 onwards, I think the tests pass bc high versions of pandas (>2.0) are compiled when reinstalling. Are we comfortable with bumping the lower pin to 1.5.0?
There was a problem hiding this comment.
Yeah I'm comfortable with that. Even 1.5 is very old.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating
pyproject.tomlandrequirements.txt