Implement streaming #1298
Annotations
6 errors and 10 warnings
build (stable)
Process completed with exit code 101.
|
build (beta)
The job was canceled because "stable" failed.
|
build (beta)
Process completed with exit code 101.
|
build (nightly)
The job was canceled because "stable" failed.
|
build (nightly)
The operation was canceled.
|
minrust
Process completed with exit code 101.
|
type parameter `T` goes unused in function definition:
target/debug/build/fill_random_values-dfe7938719c32a86/out/fill_capnp.rs#L2431
warning: type parameter `T` goes unused in function definition
--> /home/runner/work/capnproto-rust/capnproto-rust/target/debug/build/fill_random_values-dfe7938719c32a86/out/fill_capnp.rs:2431:28
|
2431 | pub fn get_field_types<T>(index: u16) -> ::capnp::introspect::Type where T: ::capnp::traits::Owned {
| ^
|
= help: consider removing the parameter
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
= note: `#[warn(clippy::extra_unused_type_parameters)]` on by default
|
type parameter `T` goes unused in function definition:
target/debug/build/fill_random_values-dfe7938719c32a86/out/fill_capnp.rs#L2434
warning: type parameter `T` goes unused in function definition
--> /home/runner/work/capnproto-rust/capnproto-rust/target/debug/build/fill_random_values-dfe7938719c32a86/out/fill_capnp.rs:2434:33
|
2434 | pub fn get_annotation_types<T>(child_index: Option<u16>, index: u32) -> ::capnp::introspect::Type where T: ::capnp::traits::Owned {
| ^
|
= help: consider removing the parameter
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
unneeded `return` statement:
capnp-rpc/src/flow_control.rs#L130
warning: unneeded `return` statement
--> capnp-rpc/src/flow_control.rs:130:21
|
130 | return Promise::ok(());
| ^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
130 - return Promise::ok(());
130 + Promise::ok(())
|
|
unneeded `return` statement:
capnp-rpc/src/flow_control.rs#L134
warning: unneeded `return` statement
--> capnp-rpc/src/flow_control.rs:134:21
|
134 | / return Promise::from_future(async {
135 | | match rcv.await {
136 | | Ok(r) => r,
137 | | Err(e) => Err(crate::canceled_to_error(e)),
138 | | }
139 | | });
| |______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
134 ~ Promise::from_future(async {
135 + match rcv.await {
136 + Ok(r) => r,
137 + Err(e) => Err(crate::canceled_to_error(e)),
138 + }
139 ~ })
|
|
unneeded `return` statement:
capnp-rpc/src/flow_control.rs#L142
warning: unneeded `return` statement
--> capnp-rpc/src/flow_control.rs:142:37
|
142 | State::Failed(ref e) => return Promise::err(e.clone()),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
|
142 | State::Failed(ref e) => Promise::err(e.clone()),
| ~~~~~~~~~~~~~~~~~~~~~~~
|
returning the result of a `let` binding from a block:
capnp-rpc/src/rpc.rs#L1864
warning: returning the result of a `let` binding from a block
--> capnp-rpc/src/rpc.rs:1864:9
|
1857 | / let flow_promise = flow.send(
1858 | | message,
1859 | | Promise::from_future(async move {
1860 | | let _ = promise.await?;
1861 | | Ok(())
1862 | | }),
1863 | | );
| |__________- unnecessary `let` binding
1864 | flow_promise
| ^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
1857 ~
1858 ~ flow.send(
1859 + message,
1860 + Promise::from_future(async move {
1861 + let _ = promise.await?;
1862 + Ok(())
1863 + }),
1864 + )
|
|
this match could be replaced by its body itself:
target/debug/build/pubsub-fb4d039551952a26/out/pubsub_capnp.rs#L87
warning: this match could be replaced by its body itself
--> /home/runner/work/capnproto-rust/capnproto-rust/target/debug/build/pubsub-fb4d039551952a26/out/pubsub_capnp.rs:87:7
|
87 | / match method_id {
88 | | _ => { ::capnp::capability::DispatchCallResult::new(::capnp::capability::Promise::err(::capnp::Error::unimplemented("Method not i...
89 | | }
| |_______^ help: consider using the match body instead: `::capnp::capability::DispatchCallResult::new(::capnp::capability::Promise::err(::capnp::Error::unimplemented("Method not implemented.".to_string())), false)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding
= note: `#[warn(clippy::match_single_binding)]` on by default
|
type parameter `T` goes unused in function definition:
target/debug/build/pubsub-fb4d039551952a26/out/pubsub_capnp.rs#L412
warning: type parameter `T` goes unused in function definition
--> /home/runner/work/capnproto-rust/capnproto-rust/target/debug/build/pubsub-fb4d039551952a26/out/pubsub_capnp.rs:412:35
|
412 | pub fn get_annotation_types<T>(child_index: Option<u16>, index: u32) -> ::capnp::introspect::Type where T: ::capnp::traits::Owned {
| ^
|
= help: consider removing the parameter
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
= note: `#[warn(clippy::extra_unused_type_parameters)]` on by default
|
type parameter `T` goes unused in function definition:
target/debug/build/pubsub-fb4d039551952a26/out/pubsub_capnp.rs#L625
warning: type parameter `T` goes unused in function definition
--> /home/runner/work/capnproto-rust/capnproto-rust/target/debug/build/pubsub-fb4d039551952a26/out/pubsub_capnp.rs:625:30
|
625 | pub fn get_field_types<T>(index: u16) -> ::capnp::introspect::Type where T: ::capnp::traits::Owned {
| ^
|
= help: consider removing the parameter
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|
type parameter `T` goes unused in function definition:
target/debug/build/pubsub-fb4d039551952a26/out/pubsub_capnp.rs#L631
warning: type parameter `T` goes unused in function definition
--> /home/runner/work/capnproto-rust/capnproto-rust/target/debug/build/pubsub-fb4d039551952a26/out/pubsub_capnp.rs:631:35
|
631 | pub fn get_annotation_types<T>(child_index: Option<u16>, index: u32) -> ::capnp::introspect::Type where T: ::capnp::traits::Owned {
| ^
|
= help: consider removing the parameter
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters
|