Skip to content

add clippy linting CI target #1017

add clippy linting CI target

add clippy linting CI target #1017

Triggered via pull request November 29, 2023 06:07
Status Failure
Total duration 4m 57s
Artifacts

ci.yml

on: pull_request
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

1 error and 18 warnings
lint
Clippy had exited with the 101 exit code
formatting
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
formatting
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
formatting
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
formatting
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
formatting
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
unsafe function's docs miss `# Safety` section: capnp/src/private/arena.rs#L40
warning: unsafe function's docs miss `# Safety` section --> capnp/src/private/arena.rs:40:5 | 40 | / unsafe fn check_offset( 41 | | &self, 42 | | segment_id: u32, 43 | | start: *const u8, 44 | | offset_in_words: i32, 45 | | ) -> Result<*const u8>; | |___________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc = note: `#[warn(clippy::missing_safety_doc)]` on by default
very complex type used. Consider factoring parts into `type` definitions: capnp/src/private/capability.rs#L40
warning: very complex type used. Consider factoring parts into `type` definitions --> capnp/src/private/capability.rs:40:10 | 40 | ) -> Option<( | __________^ 41 | | u32, 42 | | crate::capability::Promise<(), crate::Error>, 43 | | Box<dyn PipelineHook>, 44 | | )>; | |______^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default
unsafe function's docs miss `# Safety` section: capnp/src/private/layout.rs#L162
warning: unsafe function's docs miss `# Safety` section --> capnp/src/private/layout.rs:162:5 | 162 | pub unsafe fn target(ptr: *const Self) -> *const u8 { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
this function has too many arguments (10/7): capnp/src/private/layout.rs#L2149
warning: this function has too many arguments (10/7) --> capnp/src/private/layout.rs:2149:5 | 2149 | / pub unsafe fn copy_pointer( 2150 | | dst_arena: &mut dyn BuilderArena, 2151 | | dst_segment_id: u32, 2152 | | dst_cap_table: CapTableBuilder, ... | 2159 | | canonicalize: bool, 2160 | | ) -> Result<SegmentAnd<*mut u8>> { | |____________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
unsafe function's docs miss `# Safety` section: capnp/src/private/layout.rs#L2885
warning: unsafe function's docs miss `# Safety` section --> capnp/src/private/layout.rs:2885:5 | 2885 | pub unsafe fn get_root_unchecked<'b>(location: *const u8) -> PointerReader<'b> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
unsafe function's docs miss `# Safety` section: capnp/src/private/layout.rs#L3888
warning: unsafe function's docs miss `# Safety` section --> capnp/src/private/layout.rs:3888:5 | 3888 | / pub unsafe fn is_canonical( 3889 | | &self, 3890 | | read_head: &Cell<*const u8>, 3891 | | reff: *const WirePointer, 3892 | | ) -> Result<bool> { | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
methods called `into_*` usually take `self` by value: capnp/src/private/layout.rs#L4094
warning: methods called `into_*` usually take `self` by value --> capnp/src/private/layout.rs:4094:34 | 4094 | pub(crate) fn into_raw_bytes(&self) -> &'a mut [u8] { | ^^^^^ | = help: consider choosing a less ambiguous name = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention = note: `#[warn(clippy::wrong_self_convention)]` on by default
casting to the same type is unnecessary (`usize` -> `usize`): capnp/src/serialize.rs#L403
warning: casting to the same type is unnecessary (`usize` -> `usize`) --> capnp/src/serialize.rs:403:24 | 403 | let end = start + (total_body_words as usize * 8); | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `total_body_words` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default
Miri
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Miri
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Miri
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Miri
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Miri
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/