Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of capnproto/capnproto#1807 for allowing
List(T)
in schemas. Essentially, it is treated as an AnyList parameter on the wire, but the type information is preserved in the schema, which allows the C++ version to implement a proxy List(T) over the AnyList that enforces the correct type usage.I could not find an equivalent to capnp-c++'s
AnyList
class, it appears that AnyLists are simply converted toany_pointer
s and it is left to the user to cast them appropriately. So, this change simply replaces rejecting aList(AnyPointer)
by replacing it with anany_pointer
, the same wayAnyList
is handled. This change doesn't break any existing tests, but also does not add any tests either, because any test for this feature would have to be gated behind whatever version of capnp ends up incorporating List(T) support.It may be possible to restrict the acceptance of
List(AnyPointer)
to only cases where theany_pointer
is an actual parameter (which is what was done in the C++ version) but I wasn't sure how to do that.