Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Results::set_pipeline() #515

Merged
merged 5 commits into from
Sep 9, 2024
Merged

Implement Results::set_pipeline() #515

merged 5 commits into from
Sep 9, 2024

Conversation

dwrensha
Copy link
Member

@dwrensha dwrensha commented Sep 8, 2024

This provides the same functionality as capnproto-c++'s CallContext::setPipeline(), but with a slightly different API.

Whereas in capnproto-c++ setPipeline() requires usage of a PipelineBuilder, here we just re-use the existing Results message. You call set_pipeline() after you've filled in the capabilities in the result message, and then the RPC system is allowed to start running pipelined calls on the capabilities.

This provides the same functionality as capnproto-c++'s
`CallContext::setPipeline()`, but with a slightly different API.

Whereas in capnproto-c++ `setPipeline()` requires usage of a PipelineBuilder,
here we just re-use the existing Results message.
@dwrensha dwrensha merged commit bcfb07a into master Sep 9, 2024
8 checks passed
@dwrensha dwrensha deleted the set-pipeline branch September 9, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant