Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clang tidy quality of life #2348

Merged
merged 2 commits into from
May 8, 2024
Merged

Clang tidy quality of life #2348

merged 2 commits into from
May 8, 2024

Conversation

Rot127
Copy link
Collaborator

@Rot127 Rot127 commented May 1, 2024 •
edited
Loading

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

Small clang-tidy improvements:

  • Print the warnings of clang-tidy for the CI
  • Check for necessary env vars, this also prevents failing of the test when pushed to next happen.

Test plan

...

Closing issues

...

@Rot127 Rot127 force-pushed the clang-tidy-ext branch from 3a20e25 to 6bf96ab Compare May 1, 2024 13:17
XVilka
XVilka suggested changes May 5, 2024
View reviewed changes
Copy link
Contributor

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kabeor and this one

@kabeor kabeor merged commit 0002f10 into capstone-engine:next May 8, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVilka XVilka XVilka requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rot127 @XVilka @kabeor