Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python bindings: Enable more archs + bump cibuildwheel action to the v2.22.0 #2558

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

Antelox
Copy link
Contributor

@Antelox Antelox commented Nov 25, 2024

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

  • Un-comment the matrix elements for the archs different from x86
  • Bump pypa/cibuildwheel action to v2.23.0

Test plan

...

Closing issues

...

- Un-comment the matrix elements for the archs different from x86
- Bump pypa/cibuildwheel action to v2.23.0
@github-actions github-actions bot added the Github-files Github related files label Nov 25, 2024
Copy link
Collaborator

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you are at it. Please add

# Automatically cancel any previous workflow on new push.
concurrency:
  group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name }}
  cancel-in-progress: true

Otherwise the runs are not canceled on a new push.
Otherwise looks good.

@Antelox Antelox requested a review from Rot127 November 26, 2024 15:33
Copy link
Member

@kabeor kabeor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kabeor kabeor merged commit a428133 into capstone-engine:next Dec 5, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Github-files Github related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants