Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linking issue on Windows. #2587

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Fix linking issue on Windows. #2587

merged 1 commit into from
Dec 26, 2024

Conversation

Rot127
Copy link
Collaborator

@Rot127 Rot127 commented Dec 18, 2024

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

Inline functions are apparently not exposed with default visibility.

Test plan

...

Closing issues

closes #2585

@Rot127
Fix linking issue on Windows.
b4f2e64 
Inline functions are apparently not exposed with default visibility.
Fixes: capstone-engine#2585
@github-actions github-actions bot added the BPF Arch label Dec 18, 2024
kabeor
kabeor approved these changes Dec 26, 2024
View reviewed changes
Copy link
Member

@kabeor kabeor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.

@kabeor kabeor merged commit 186f7aa into capstone-engine:next Dec 26, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kabeor kabeor kabeor approved these changes

Assignees
No one assigned
Labels
BPF Arch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build fails with: unresolved external symbol BPF_getFeature.
2 participants
@Rot127 @kabeor