-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tricore tc1.8 instructions #2595
base: next
Are you sure you want to change the base?
Add tricore tc1.8 instructions #2595
Conversation
add.df sub.df madd.df msub.df mul.df div.df cmp.df max.df min.df min.f max.f dftoi dftoiz dftoin ftoin dftou dftouz dftol dftoul dftoulz abs.f abs.df dftolz neg.df neg.f qseed.df itodf utodf ltodf ultodf dftof ftodf
div64 div64.u rem64 rem64.u
Since this PR is not merged yet. I added a bit more instructions
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try to find time for a full review on the weekend. But please don't forget to add tests for the instruction details in tests/details
.
@Rot127 Thank you very much for review. But I still have a question. The tests under |
The MC tests are copies of the assembler/disassembler regression tests from LLVM. They get translated from the LLVM format to our yaml test files with the Auto-Sync. The detail tests on the other hand, test the code added by Capstone. So all the details. They should (but don't, yet) cover all functions in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely! Thanks a lot!
Just address those small comments please. Otherwise lgtm.
@kabeor
Your checklist for this pull request
Detailed description
Add tricore tc1.8 instructions:
The inc files are updated by:
capstone-engine/llvm-capstone#73
...
Test plan
...
Closing issues
...