bugfix: avoid logging non-200 response and don't publish mesasge when there is error #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiopramayudi
approved these changes
Apr 18, 2024
khorshuheng
force-pushed
the
prevent-publishing-empty-value-message
branch
from
ea676ec
to
a5a3099
Compare
khorshuheng
force-pushed
the
prevent-publishing-empty-value-message
branch
from
a5a3099
to
ceb306f
Compare
khorshuheng
added a commit
that referenced
this pull request
Apr 18, 2024
… there is error (#573) <!-- Thanks for sending a pull request! Here are some tips for you: 1. Run unit tests and ensure that they are passing 2. If your change introduces any API changes, make sure to update the e2e tests 3. Make sure documentation is updated for your PR! --> # Description <!-- Briefly describe the motivation for the change. Please include illustrations where appropriate. --> Currently, empty message might be published when there is non-200 response, or when there is error building the Kafka log. The observation publisher will crash as a result because the consumer currently doesn't handle the scenario when the Kafka message value is null. # Modifications <!-- Summarize the key code changes. --> - Prevent producing Kafka message when the response code is not 200, or when there is error building the Kafka log. - Skip message with null message for the observation publisher # Tests <!-- Besides the existing / updated automated tests, what specific scenarios should be tested? Consider the backward compatibility of the changes, whether corner cases are covered, etc. Please describe the tests and check the ones that have been completed. Eg: - [x] Deploying new and existing standard models - [ ] Deploying PyFunc models --> # Checklist - [ ] Added PR label - [ ] Added unit test, integration, and/or e2e tests - [ ] Tested locally - [ ] Updated documentation - [ ] Update Swagger spec if the PR introduce API changes - [ ] Regenerated Golang and Python client if the PR introduces API changes # Release Notes <!-- Does this PR introduce a user-facing change? If no, just write "NONE" in the release-note block below. If yes, a release note is required. Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required". For more information about release notes, see kubernetes' guide here: http://git.k8s.io/community/contributors/guide/release-notes.md --> ```release-note ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, empty message might be published when there is non-200 response, or when there is error building the Kafka log. The observation publisher will crash as a result because the consumer currently doesn't handle the scenario when the Kafka message value is null.
Modifications
Tests
Checklist
Release Notes