Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update github actions and its dependencies #585

Merged
merged 9 commits into from
May 21, 2024

Conversation

ariefrahmansyah
Copy link
Contributor

@ariefrahmansyah ariefrahmansyah commented May 17, 2024

Description

Maintenance PR that updates Merlin GitHub actions and its workflows' dependencies.

The goal is basically to fix all these annotations warning:

https://github.com/caraml-dev/merlin/actions/runs/9106445873

image

to:

https://github.com/caraml-dev/merlin/actions/runs/9125329491

image

Note that updating nodejs from 16 to newer one will be in separate PR, in the future.

Modifications

  1. Update GitHub Actions' workflows versions
  2. Remove CodeSee GitHub actions as it's no longer providing services and acquired by GitKraken ref
  3. Refactor caching mechanisms

Tests

Checklist

  • Added PR label
  • Added unit test, integration, and/or e2e tests
  • Tested locally
  • Updated documentation
  • Update Swagger spec if the PR introduce API changes
  • Regenerated Golang and Python client if the PR introduces API changes

Release Notes


@ariefrahmansyah ariefrahmansyah added the maintenance Dependency updates and other chores label May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.29%. Comparing base (7506c07) to head (d7cfa9f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #585   +/-   ##
=======================================
  Coverage   60.29%   60.29%           
=======================================
  Files         274      274           
  Lines       21930    21930           
=======================================
  Hits        13223    13223           
  Misses       7857     7857           
  Partials      850      850           
Flag Coverage Δ
api-test 58.22% <ø> (ø)
sdk-test-3.10 75.47% <ø> (ø)
sdk-test-3.8 75.40% <ø> (ø)
sdk-test-3.9 75.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ariefrahmansyah ariefrahmansyah changed the title Update github actions chore: Update github actions and its dependencies May 17, 2024
@ariefrahmansyah ariefrahmansyah marked this pull request as ready for review May 17, 2024 09:04
Copy link
Contributor

@leonlnj leonlnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks LGTM!

@ariefrahmansyah ariefrahmansyah merged commit c5afcf8 into main May 21, 2024
36 checks passed
@ariefrahmansyah ariefrahmansyah deleted the fix-github-actions-warnings branch May 21, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Dependency updates and other chores
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants