Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cicd): Fix invalid pip installation commands #610

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

deadlycoconuts
Copy link
Contributor

@deadlycoconuts deadlycoconuts commented Sep 23, 2024

Description

In PR #608, the version of setuptools was pinned to <75. However, this wasn't done correctly for the pip installation command, causing the CICD pipeline to fail when publishing new versions of the Merlin SDK, batch predictor and pyfunc server to PyPI. This PR simply corrects that invalid command.

Modifications

  • .github/workflows/release.yml - Fix incorrect pip installation command

Tests

Checklist

  • Added PR label
  • Added unit test, integration, and/or e2e tests
  • Tested locally
  • Updated documentation
  • Update Swagger spec if the PR introduce API changes
  • Regenerated Golang and Python client if the PR introduces API changes

Release Notes

NONE

@deadlycoconuts deadlycoconuts added the bug Something isn't working label Sep 23, 2024
@deadlycoconuts deadlycoconuts self-assigned this Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.70%. Comparing base (dd17c90) to head (226120c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #610   +/-   ##
=======================================
  Coverage   60.70%   60.70%           
=======================================
  Files         275      275           
  Lines       22171    22171           
=======================================
  Hits        13460    13460           
  Misses       7847     7847           
  Partials      864      864           
Flag Coverage Δ
api-test 58.68% <ø> (ø)
sdk-test-3.10 75.51% <ø> (ø)
sdk-test-3.8 75.49% <ø> (ø)
sdk-test-3.9 75.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deadlycoconuts deadlycoconuts force-pushed the fix_invalid_pip_installation_command branch from 4a61ffd to 8a293ea Compare September 23, 2024 08:59
@deadlycoconuts deadlycoconuts force-pushed the fix_invalid_pip_installation_command branch from 226120c to 8a293ea Compare September 23, 2024 09:27
@deadlycoconuts deadlycoconuts marked this pull request as ready for review September 23, 2024 09:29
@deadlycoconuts deadlycoconuts merged commit 7caf48a into main Sep 23, 2024
68 checks passed
@deadlycoconuts deadlycoconuts deleted the fix_invalid_pip_installation_command branch September 23, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants