feat(mlflow): Update Mlflow, API server, pyfunc server and batch predictor #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deadlycoconuts
force-pushed
the
update_mlflow_in_non_sdk_components
branch
from
8690f51
to
26131d9
Compare
deadlycoconuts
force-pushed
the
update_mlflow_in_non_sdk_components
branch
from
26131d9
to
d7b4e48
Compare
deadlycoconuts
commented
Nov 15, 2024
deadlycoconuts
force-pushed
the
update_mlflow_in_non_sdk_components
branch
7 times, most recently
from
2325428
to
7d0330d
Compare
deadlycoconuts
force-pushed
the
update_mlflow_in_non_sdk_components
branch
from
7680aba
to
5a4e9fc
Compare
deadlycoconuts
commented
Nov 16, 2024
deadlycoconuts
commented
Nov 16, 2024
deadlycoconuts
commented
Nov 16, 2024
deadlycoconuts
commented
Nov 16, 2024
deadlycoconuts
commented
Nov 16, 2024
deadlycoconuts
requested review from
tiopramayudi,
mbruner,
shydefoo and
bthari
shydefoo
approved these changes
Nov 18, 2024
|
Thanks a lot for the quick review! :D I'll merge this soon! |
6 tasks
deadlycoconuts
added a commit
that referenced
this pull request
Nov 18, 2024
…618) # Description This PR is the **third part** (3 out of 3) of a series of PRs to update the version of Mlflow used by Merlin (to `1.26.1`*). These changes are: 1. Update the version of Mlflow used in the Merlin SDK and publish it to PyPI 2. Update - the Merlin pyfunc server and batch predictor to use the updated Merlin SDK version released in step 1 and publish them to PyPI - the Merlin API server to ensure that requests sent to Mlflow reflect the update API endpoint contracts - the Mlflow image so that it's built using version `1.26.1` 3. Update the default pyfunc server and batch predictor version in the Merlin SDK and publish its new version to PyPI Since the pyfunc server and batch predictor versions have already been updated in the PR #617, we need to ensure that the SDK is able to use these newly released versions by default. # Modifications - `python/sdk/merlin/model.py` - Update the version bounds of the default pyfunc server and batch predictor version in the SDK # Tests <!-- Besides the existing / updated automated tests, what specific scenarios should be tested? Consider the backward compatibility of the changes, whether corner cases are covered, etc. Please describe the tests and check the ones that have been completed. Eg: - [x] Deploying new and existing standard models - [ ] Deploying PyFunc models --> # Checklist - [x] Added PR label - [ ] Added unit test, integration, and/or e2e tests - [x] Tested locally - [ ] Updated documentation - [ ] Update Swagger spec if the PR introduce API changes - [ ] Regenerated Golang and Python client if the PR introduces API changes # Release Notes ```release-note NONE ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is the second part (2 out of 3) of a series of PRs to update the version of Mlflow used by Merlin (to
1.26.1*). These changes are:1.26.1Main Modifications
.github/workflows/external.yml- Updated the CICD job to release a new version of the Mlflow imageapi/mlflow/mlflow.go- Added a header in all requests sent to the Mlflow server from the Merlin API server because it's now requiredapi/mlflow/response.go- Changed the data type of certain fields in Mlflow's responses sent to Merlinmlflow/Dockerfile- Updated Dockerfile of the Mlflow server with newer dependenciespython/batch-predictor/requirements.txt- Updated the requirements file with a newer version of the SDK which requires version1.26.1of Mlflowpython/pyfunc-server/requirements.txt- Updated the requirements file with a newer version of the SDK which requires version1.26.1of MlflowTests
Checklist
Release Notes