Test namespace changed and new ImagesNotFound test added to the pdf

caraplana1 · Aug 4, 2024 · 11fb3aa · 11fb3aa
1 parent 16db108
commit 11fb3aa
Show file tree

Hide file tree

Showing 9 changed files with 48 additions and 24 deletions.
diff --git a/ComicConverter/ComicBuilder.cs b/ComicConverter/ComicBuilder.cs
@@ -60,6 +60,9 @@ public static void CreatePdf(string[] imagesPaths, string fileName)
                                             || f.EndsWith(".JPEG", StringComparison.OrdinalIgnoreCase)
                                             || f.EndsWith(".JPG", StringComparison.OrdinalIgnoreCase)).ToArray();
 
+            if (imagesPaths.Length is 0)
+                throw new IOException();
+
             PdfDocument document = new();
             document.Info.Title = fileName.Replace('\\', '/').Split('/').Last();
 

diff --git a/Tests/ComicConverter.cs b/Tests/ComicConverter.cs
@@ -1,10 +1,11 @@
+using Test;
 using Xunit;
 using System;
 using System.IO;
 using ComicConverter;
 using ComicConverter.Enums;
 
-namespace Test
+namespace Tests
 {
     public class ComicConverter
     {
@@ -70,7 +71,6 @@ public void OutInvalidFormat()
         public void InInvalidFormat()
         {
             Comic comic;
-
             Assert.Throws<FormatException>(() => comic = new(Samples.Testpath));
         }
     }

diff --git a/Tests/ComicCreators/CbtFiles.cs b/Tests/ComicCreators/CbtFiles.cs
@@ -1,13 +1,15 @@
+using Test;
 using Xunit;
+using System;
 using System.IO;
 using ComicConverter;
 
-namespace Test.ComicCreators
+namespace Tests.ComicCreators
 {
     public class CbtFiles
     {
         private const string CbtPath = "CreatedCbtFileTest";
-
+        
         [Fact]
         public void CreateCbt()
         {
@@ -23,9 +25,9 @@ public void CreateCbt()
         [Fact]
         public void ImagesNotFound()
         {
-            string[] fakeFiles = ["fakefile1.jpg", "fakefile2.jpg", "fakefile3.jpg"];
+            string[] files = ["fakefile.jpg", "fakefile1.jpg", "fakefile2.jpg"];
 
-            Assert.Throws<IOException>(() => ComicBuilder.CreateCbt(fakeFiles, CbtPath));
+            Assert.Throws<IOException>(() => ComicBuilder.CreateCbt(files, CbtPath));
         }
     }
 }
diff --git a/Tests/ComicCreators/CbzFiles.cs b/Tests/ComicCreators/CbzFiles.cs
@@ -1,8 +1,10 @@
+using Test;
 using Xunit;
+using System;
 using System.IO;
 using ComicConverter;
 
-namespace Test.ComicCreators
+namespace Tests.ComicCreators
 {
     public class CbzFiles
     {

diff --git a/Tests/ComicCreators/PdfFiles.cs b/Tests/ComicCreators/PdfFiles.cs
@@ -1,9 +1,10 @@
+using Test;
 using Xunit;
 using System;
 using System.IO;
 using ComicConverter;
 
-namespace Test.ComicCreators
+namespace Tests.ComicCreators
 {
     public class PdfFiles
     {
@@ -29,5 +30,13 @@ public void FilesAreNotImages()
 
             Assert.ThrowsAny<Exception>(() => ComicBuilder.CreatePdf(images, Path));
         }
+
+        [Fact]
+        public void ImagesNotFound()
+        {
+            string[] files = ["Fakename", "fakename2", "fakename3"];
+
+            Assert.Throws<IOException>(() => ComicBuilder.CreatePdf(files, Path));
+        }
     }
 }
diff --git a/Tests/ImageCollectors/CbrFiles.cs b/Tests/ImageCollectors/CbrFiles.cs
@@ -1,9 +1,10 @@
+using Test;
 using Xunit;
 using System.IO;
 using ComicConverter;
 using System.Collections.Generic;
 
-namespace Test.ImageCollector
+namespace Tests.ImageCollectors
 {
     public class CbrFiles
     {
@@ -12,11 +13,10 @@ public class CbrFiles
         public void Unrar()
         {
             string outputDir = "CbrTest1";
-            int extractedFiles;
 
             ImageExporter.UnRar(Samples.Cbrpath, outputDir);
 
-            extractedFiles = Directory.GetFiles(outputDir).Length;
+            var extractedFiles = Directory.GetFiles(outputDir).Length;
             Directory.Delete(outputDir, true);
             Assert.Equal(3, extractedFiles);
         }

diff --git a/Tests/ImageCollectors/CbtFiles.cs b/Tests/ImageCollectors/CbtFiles.cs
@@ -1,10 +1,11 @@
-using System.IO;
 using System;
+using System.IO;
 using System.Linq;
 using ComicConverter;
+using Test;
 using Xunit;
 
-namespace Test.ImageCollector
+namespace Tests.ImageCollectors
 {
     public class CbtFiles
     {

diff --git a/Tests/ImageCollectors/CbzFiles.cs b/Tests/ImageCollectors/CbzFiles.cs
@@ -1,9 +1,10 @@
+using Test;
 using Xunit;
 using System.IO;
 using ComicConverter;
 using System.Collections.Generic;
 
-namespace Test.ImageCollector
+namespace Tests.ImageCollectors
 {
     public class CbzFiles
     {

diff --git a/Tests/ImageCollectors/PdfFiles.cs b/Tests/ImageCollectors/PdfFiles.cs
@@ -1,32 +1,38 @@
+using Test;
+using Xunit;
 using System;
 using System.IO;
 using ComicConverter;
-using Xunit;
 
-namespace Test.ImageCollector
+namespace Tests.ImageCollectors
 {
     public class PdfFiles
     {
         [Fact]
-        public void ExtractImagesPdf()
+        public void ExtractImagesJpgPdf()
         {
             string pdfDir = "PdfExtractedImages";
-            string pdfPngDir = "PdfPNGExtractedImages";
-
             ImageExporter.ExportPdfImages(Samples.Pdfpath, pdfDir);
-            ImageExporter.ExportPdfImages(Samples.Pdfpngpath, pdfPngDir);
-
             var files = Directory.GetFiles(pdfDir).Length;
-            var filesPng = Directory.GetFiles(pdfPngDir).Length;
 
             Directory.Delete(pdfDir, true);
-            Directory.Delete(pdfPngDir, true);
 
             Assert.Equal(3, files);
-            Assert.Equal(3, filesPng);
 
         }
 
+        [Fact]
+        public void ExtractImagesPngPdf()
+        {
+            string pdfPngDir = "PdfPNGExtractedImages";
+            ImageExporter.ExportPdfImages(Samples.Pdfpngpath, pdfPngDir);
+            var filesPng = Directory.GetFiles(pdfPngDir).Length;
+
+            Directory.Delete(pdfPngDir, true);
+
+            Assert.Equal(3, filesPng);
+        }
+
         [Fact]
         public void FileIsNotPdf()
         {