-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): fix issue where legend component ids are not unique #1688
fix(core): fix issue where legend component ids are not unique #1688
Conversation
✅ Deploy Preview for carbon-charts-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-charts-core ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-charts-angular ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
DCO Assistant Lite bot All contributors have signed the DCO. |
this commit will initialize a chartId in the domutils class when an instance of the class is created... this ensures that any ids generated by the domutils can be unique based on that id carbon-design-system#1619
8492590
to
9407f9a
Compare
I have read the DCO document and I hereby sign the DCO. |
Hi @joker23, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment above
…s into fix-id-collision-in-legend
Hey @theiliad - I did a quick test and it looks like the
Theoretically if the dom util service is shared between the chart and the legend then they should be the same value, but I got: Thoughts?
|
I believe this was fixed by @RiyaJethwa. IDs seem to be correct on storybook, pls lmk if this PR still applies |
#1619
Updates
this commit will initialize a chartId in the domutils class when an instance of the class is created... this ensures that any ids generated by the domutils can be unique based on that id
Demo screenshot or recording
chart legend id will now have a unique id component