fix(modal-domUtils):chartID initialization and addition of chartID in modal ARIA attributes #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… modal ARIA attributes
✅ Deploy Preview for carbon-charts-core ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-charts-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-charts-angular ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I have read the DCO document and I hereby sign the DCO. |
theiliad
requested changes
Jan 10, 2024
| .attr('aria-labelledby', 'modal-title') | ||
| .attr('aria-describedby', 'modal-description') | ||
| .attr('aria-labelledby', `${id}__modal-title`) | ||
| .attr('aria-describedby', `${id}__modal-description`) |
There was a problem hiding this comment.
these just point to an ID, but you also need to set these IDs to the modal
(currently the modal IDs are set to modal-title & modal-description, so we need to add the ${id}__ in there
theiliad
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
chartIDpreviously not getting initialized byinit()has been fixedchartIDinaria-labelledbyandaria-describedbyattributesDemo screenshot or recording