fix: ensure proper namespace for title attr

carbon-design-system · Nov 29, 2024 · 24ffbfe · 24ffbfe
1 parent a2a9228
commit 24ffbfe
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/icon/icon.directive.ts b/src/icon/icon.directive.ts
@@ -81,7 +81,8 @@ export class IconDirective implements AfterViewInit, OnChanges {
 		}
 
 		const svg = root.tagName.toUpperCase() !== "SVG" ? svgElement : root;
-		svg.setAttribute("xmlns", "http://www.w3.org/2000/svg");
+		const xmlns = "http://www.w3.org/2000/svg";
+		svg.setAttribute("xmlns", xmlns);
 
 		const attributes = getAttributes({
 			width: icon.attrs.width,
@@ -110,7 +111,7 @@ export class IconDirective implements AfterViewInit, OnChanges {
 		}
 
 		if (attributes["title"]) {
-			const title = document.createElement("title");
+			const title = document.createElementNS(xmlns, "title");
 			title.textContent = attributes.title;
 			IconDirective.titleIdCounter++;
 			title.setAttribute("id", `${icon.name}-title-${IconDirective.titleIdCounter}`);