feat: add BreadcrumbSkeleton component #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lee-chase
requested changes
Feb 13, 2019
| @@ -0,0 +1,15 @@ | |||
| <template> | |||
| <div class="bx--breadcrumb-item"> | |||
| <a href="/#" class="bx--link"> | |||
There was a problem hiding this comment.
This should be disabled (as other active content e.g. button in CvAccordionItemSkeleton).
Use the following for link
aria-disabled tabindex="-1"
The same for buttons, input etc if setting disabled has other visual consequences.
There was a problem hiding this comment.
Looks like it's enough to remove its href attribute to fix this. Is it ok?
|
Fine with me.
Regards Lee
On 13 Feb 2019, at 13:37, Aleksandr Sabov <[email protected]<mailto:[email protected]>> wrote:
@sabov commented on this pull request.
________________________________
In src/components/cv-breadcrumb/_cv-breadcrumb-item-skeleton.vue<#200 (comment)>:
@@ -0,0 +1,15 @@
+<template>
+ <div class="bx--breadcrumb-item">
+ <a href="/#" class="bx--link">
Looks like it's enough to remove its href attribute to fix this. Is it ok?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#200 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AOY0DCi8Jefmj6JKWVNhcz5asPmCTFqnks5vNBUdgaJpZM4a5H5Y>.
|
lee-chase
approved these changes
Feb 13, 2019
dcwarwick
pushed a commit
to dcwarwick/carbon-components-vue
that referenced
this pull request
Mar 18, 2019
* feat: add AccordionSkeleton and SkeletonText components * feat: add BreadcrumbSkeleton component * chore: disable active elements like links and buttons
dcwarwick
pushed a commit
to dcwarwick/carbon-components-vue
that referenced
this pull request
Mar 18, 2019
* feat: add AccordionSkeleton and SkeletonText components * feat: add BreadcrumbSkeleton component * chore: disable active elements like links and buttons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #167
Adds
CvBreadcrumbSkeletoncomponents. UpdatesCvBreadcrumbstory.Changelog
New
CvBreadcrumbSkeletonChanged
CvBreadcrumbstory